Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven pom refers to incorrect support library version #107

Closed
hborders opened this issue Feb 7, 2014 · 0 comments · Fixed by #108
Closed

Maven pom refers to incorrect support library version #107

hborders opened this issue Feb 7, 2014 · 0 comments · Fixed by #108

Comments

@hborders
Copy link

hborders commented Feb 7, 2014

We should use the support library naming standard from maven-android-sdk-deployer which seems to be the best way to deploy the support libraries into a maven repository. Currently, we refer to com.android.support:support-v4:13.0.0, which I think is actually supposed to correspond to $ANDROID_HOME/extras/android/support/v13/android-support-v13.jar. maven-android-sdk-deployer calls that com.google.android:support-v13:19.0.1 It uses the version reported from the Android SDK Manager, and we should do the same.

I'll submit a PR later tonight.

hborders pushed a commit to hborders/AndroidSlidingUpPanel that referenced this issue Feb 8, 2014
hborders pushed a commit to hborders/AndroidSlidingUpPanel that referenced this issue Feb 10, 2014
tokudu added a commit that referenced this issue Feb 12, 2014
…compatibility_version

Fixed #107. Used maven-android-sdk-deployer support version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant