Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate linting and tests in Github Actions #33

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Conversation

sritchie
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 One small request.

@@ -16,5 +17,4 @@ jobs:
cache-dependency-path: package-lock.json
- run: npm ci
- run: npm run format
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested Change: This happens in linting, so I think we can remove it from the tests job.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@sritchie sritchie merged commit 89ea131 into master Apr 18, 2022
@sritchie sritchie deleted the sritchie/actions branch April 18, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants