-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CodePointSet to CodePointInversionList #2230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils/uniset/README.md
Outdated
represented by [inversion lists](http://userguide.icu-project.org/strings/properties), | ||
the [`CodePointSetBuilder`], or from the TBA Properties API. | ||
the [`CodePointInversionListBuilder`], or from the TBA Properties API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The properties API is no longer "TBA"; fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
utils/uniset/src/uniset.rs
Outdated
} | ||
|
||
/// Returns an owned inversion list representing the current [`CodePointSet`] | ||
/// Returns an owned inversion list representing the current [`CodePointInversionList`] | ||
pub fn get_inversion_list(&self) -> Vec<u32> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: name this get_inversion_list_vec()
since the type is now called an "inversion list" too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(setting review bit appropriately)
Co-authored-by: Shane F. Carr <shane@unicode.org>
test-docs is unhappy
|
Fixes #2225