Unifying DataLocale construction
#4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
aethanyc,
makotokato,
zbraniecki,
dminor,
snktd,
eggrobin,
nordzilla,
hsivonen,
echeran and
a team
as code owners
robertbastian
removed request for
aethanyc,
dminor,
zbraniecki,
hsivonen,
echeran,
makotokato,
eggrobin,
nordzilla and
snktd
sffc
approved these changes
May 21, 2024
| @@ -832,8 +831,8 @@ mod tests { | |||
| use icu_calendar::japanese::JapaneseExtended; | |||
| use icu_calendar::Date; | |||
|
|
|||
| let locale: Locale = "en-u-ca-japanese".parse().unwrap(); | |||
| let dtf = NeoDateFormatter::try_new_with_length(&locale.into(), length::Date::Medium) | |||
| let locale = "en-u-ca-japanese".parse().unwrap(); | |||
There was a problem hiding this comment.
Thought: This one involves impl FromStr for DateTimePreferences
| /// | ||
| /// let zdtf = ZonedDateTimeFormatter::try_new( | ||
| /// &locale.into(), | ||
| /// &locale, |
There was a problem hiding this comment.
Thought: All of these examples assume that Preferences will be borrowed. Have we had that discussion? Because it could also be a Copy type that borrows the LanguageIdentifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #3632
There are two cases:
DataLocalesthat are passed into ICU4X constructors:locale!("foo").into(), or"foo".parse()From<Locale>impl for the preferencesDataLocalesthat are put into theDataRequest::localefield.langid!("foo").into(), or"foo".parse()&LanguageIdentifier, these can be clippy-cleaned-up, as the.into()will become redundant.I've taken care to avoid having intermediate
LocaleorLanguageIdentifiervariables, everything that is macro-constructed is immediatelyinto()ed. This will simplify find-and-replace later.