Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary light client storage #3910

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Arbitrary light client storage #3910

wants to merge 8 commits into from

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Mar 3, 2025

No description provided.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2025 11:57pm

@aeryz aeryz force-pushed the 3907-lc-arbitrary-storage branch from 7cffa08 to e27ae2c Compare March 3, 2025 19:43
@aeryz aeryz marked this pull request as ready for review March 3, 2025 19:43
@aeryz aeryz requested a review from benluelo as a code owner March 3, 2025 19:43
@aeryz aeryz force-pushed the 3907-lc-arbitrary-storage branch from b496549 to 308f6ac Compare March 3, 2025 19:52
aeryz added 4 commits March 3, 2025 22:57
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the 3907-lc-arbitrary-storage branch from 308f6ac to 5245c5b Compare March 3, 2025 20:02
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change for the ethereum light client, and will require a storage migration

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@@ -18,7 +18,7 @@ pub struct ClientState {
pub frozen_height: Height,
/// the ibc contract on the counterparty chain that contains the ICS23 commitments
pub ibc_contract_address: H160,
#[cfg_attr(feature = "serde", serde(default))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still need default lol

@benluelo
Copy link
Contributor

benluelo commented Mar 3, 2025

considering that this is a breaking change for the eth lc, lets also include the migration in this PR?

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the 3907-lc-arbitrary-storage branch from cc795b2 to de5c6f1 Compare March 3, 2025 22:44
aeryz added 2 commits March 4, 2025 02:54
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants