-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrary light client storage #3910
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
7cffa08
to
e27ae2c
Compare
b496549
to
308f6ac
Compare
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
308f6ac
to
5245c5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change for the ethereum light client, and will require a storage migration
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@@ -18,7 +18,7 @@ pub struct ClientState { | |||
pub frozen_height: Height, | |||
/// the ibc contract on the counterparty chain that contains the ICS23 commitments | |||
pub ibc_contract_address: H160, | |||
#[cfg_attr(feature = "serde", serde(default))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you still need default
lol
considering that this is a breaking change for the eth lc, lets also include the migration in this PR? |
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
cc795b2
to
de5c6f1
Compare
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
No description provided.