Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling corrections using en_US dictionary #594

Merged
merged 8 commits into from
Aug 31, 2018
Merged

spelling corrections using en_US dictionary #594

merged 8 commits into from
Aug 31, 2018

Conversation

tkphd
Copy link
Contributor

@tkphd tkphd commented Aug 30, 2018

Ran ispell from emacs against every rst and py file in FiPy. Corrected the errors it found, more or less.


This change is Reviewable

@tkphd tkphd requested review from guyer and wd15 August 30, 2018 21:35
@tkphd tkphd mentioned this pull request Aug 31, 2018
@tkphd
Copy link
Contributor Author

tkphd commented Aug 31, 2018

This new GitHub Reviews interface is an improvement. I like it.

Copy link
Member

@guyer guyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worthwhile effort, but in many places you were wrong on the internet

@@ -12,7 +12,7 @@ http://build.cmi.kent.edu:8010/
Modifying the configuration
---------------------------

The buildbot configuration file is hosted in a Git repository. To clone the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request should wait to have #591 accepted and then merge develop

@tkphd tkphd merged commit 4139939 into usnistgov:develop Aug 31, 2018
@tkphd tkphd deleted the spelling branch August 31, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants