Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing header file and include path #185

Closed
FalsinSoft opened this issue Jan 1, 2025 · 5 comments
Closed

Missing header file and include path #185

FalsinSoft opened this issue Jan 1, 2025 · 5 comments

Comments

@FalsinSoft
Copy link
Contributor

FalsinSoft commented Jan 1, 2025

Hi

In your last release there are a couple of issues. Does it compile for you?

At first inside the CMakeLists.txt there is the header file sqlite3userauth.h that was present in the previous release but is disappeared in this 2.0 release. However since is present in the CMakeLists.txt here:

set(SQLITE3MC_PUBLIC_HEADERS
  src/sqlite3.h
  src/sqlite3ext.h
  src/sqlite3mc.h
  src/sqlite3mc_version.h
  src/sqlite3mc_vfs.h
  src/sqlite3userauth.h
)

the CMake fails to generate the project files.

Another issue is inside the file src\aegis\aegis128l/implementations.h where try to include the header file aegis128l.h but this file is inside the path src/aegis/include/ and this path in not set as search path so the compilation fails cause can not find this file.

utelle added a commit that referenced this issue Jan 1, 2025
@utelle
Copy link
Owner

utelle commented Jan 1, 2025

In your last release there are a couple of issues.

Thanks for reporting the issues.

Does it compile for you?

Yes, it does. Otherwise I wouldn't have done a release.

However, I have to admit that I simply forgot to adjust the CMake support file CMakeLists.txt, because I don't use CMake myself.

At first inside the CMakeLists.txt there is the header file sqlite3userauth.h that was present in the previous release but is disappeared in this 2.0 release. However since is present in the CMakeLists.txt here:

The reference to this header file has to be removed.

Another issue is inside the file src\aegis\aegis128l/implementations.h where try to include the header file aegis128l.h but this file is inside the path src/aegis/include/ and this path in not set as search path so the compilation fails cause can not find this file.

The include paths to the respective subdirectories have to be added. I did that for the Visual C++ build files, the make files, and the autoconf files.

In commit 8a83b2d I adjusted the file CMakeLists.txt. Building with CMake should now work again, hopefully.

@FalsinSoft
Copy link
Contributor Author

Hi
Thank you for the fast fix. Since I'm in no hurry I'll wait for the official 2.0.1 release. Feel free to close this issue when you are confident of the fix.

1 similar comment
@FalsinSoft
Copy link
Contributor Author

Hi
Thank you for the fast fix. Since I'm in no hurry I'll wait for the official 2.0.1 release. Feel free to close this issue when you are confident of the fix.

@utelle
Copy link
Owner

utelle commented Jan 2, 2025

Since I'm in no hurry I'll wait for the official 2.0.1 release. Feel free to close this issue when you are confident of the fix.

The next release will be done after the release of version 3.48.0 of SQLite, which is announced for mid of January.

@utelle
Copy link
Owner

utelle commented Jan 6, 2025

Release 2.0.1 fixes the issue.

@utelle utelle closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants