Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Arrive event with onceOnly not triggered in some cases #94

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Bug fix: Arrive event with onceOnly not triggered in some cases #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/arrive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ var Arrive = (function(window, $, undefined) {
};
},
callCallbacks: function(callbacksToBeCalled, registrationData, mutationEvents) {
// firedElems check because firedElems are not added in case of leave events
if (registrationData && registrationData.options.onceOnly && registrationData.firedElems.length <= 1) {
if (!callbacksToBeCalled.length) return;

if (registrationData && registrationData.options.onceOnly) {
// as onlyOnce param is true, make sure we fire the event for only one item
callbacksToBeCalled = [callbacksToBeCalled[0]];

Expand Down