enhancement(operations): abstracts runtime into runtime.rs #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Oct 26, 2019
LucioFranco
reviewed
Oct 26, 2019
LucioFranco
reviewed
Oct 26, 2019
|
Roger, I'll address these this weekend! |
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
|
@Michael-J-Ward Hey! thank you for this! I ended up needing this for some tests I was running so I went ahead and just applied my changes, thank you a ton for doing all the heavy work! |
LucioFranco
approved these changes
Nov 1, 2019
binarylogic
changed the title
|
Thanks @Michael-J-Ward ! |
LucioFranco
changed the title
|
Hey @LucioFranco and @binarylogic , thanks for the true "Good first issue!" It was a great way for me to get my feet wet with Rust development. |
|
@Michael-J-Ward great! I hope to get more of these types of issues out! I hopefully will get to posting them to TWIR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1085
The
tokioruntime is still leaking out viaShutdownandTaskExecutortypes. I haven't taken time to investigate if those need to be wrapped or abstracted away in some other way.Additionally,
test_utilsandmain.rsused thetokio::Builderapi to control the runtime's threadcount. Instead of creating a newBuilder, I just provided alternate constructor methods onRuntime.And obviously, I haven't implemented a free standing
spawnfunction yet.But other than that, it compiles and tests are passing. Let me know what you think