communicator #103
Closed
communicator #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbald
reviewed
Jul 27, 2024
| @@ -192,6 +193,17 @@ class sender : ConnectionPolicy | |||
| [](const boost::system::error_code&, std::size_t) { | |||
| }); | |||
| } | |||
|
|
|||
| void send_async(data_segments_vector const & data) { | |||
There was a problem hiding this comment.
UDP datagram should not be larger than the MTU (1500 bytes), ASIO wouldn't care and return EMSGSIZE I think.
man 7 udp
By default, Linux UDP does path MTU (Maximum Transmission Unit) discovery.
This means the kernel will keep track of the MTU to a specific target IP
address and return EMSGSIZE when a UDP packet write exceeds it. When this
happens, the application should decrease the packet size. Path MTU discov-
ery can be also turned off using the IP_MTU_DISCOVER socket option or the
/proc/sys/net/ipv4/ip_no_pmtu_disc file; see ip(7) for details. When
turned off, UDP will fragment outgoing UDP packets that exceed the inter-
face MTU. However, disabling it is not recommended for performance and re-
liability reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.