Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support in API definition #36

Closed
wants to merge 1 commit into from

Conversation

daniele2010
Copy link

I've added the support of proxy, if you want to use a proxy you can specify it in the API definition as shown below:

import krakenex
k = krakenex.API(proxy='my.proxy.net')

@veox
Copy link
Owner

veox commented Jul 31, 2017

Ref issue: #6

@veox
Copy link
Owner

veox commented Jul 31, 2017

I'm reluctant to merge this, since v1.0.0a0 is already tagged for testing.

Also, once master is cleaned up for a proper release, and v1.0.0 actual is out, it's likely I'll just go on with the requests approach, as discussed in issue #11.

That should allow folk to use whatever way of connecting to Kraken that they see fit.


Sorry for this! I'd usually close the PR at this point, but quite a few people seem to ask for this functionality. So, let's keep it open for now, and merge into v1.1.0.

@veox veox added this to the v1.1 milestone Jul 31, 2017
@veox
Copy link
Owner

veox commented Sep 21, 2017

I've decided to instead push forward with the requests impl-n due to #53. It's now in master, and tagged as v2.0.0a1.

Sorry for dragging this out for so long.

@veox veox closed this Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants