Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify instantation of image handles with ImageFileNameProvider #235

Open
akoch-yatta opened this issue Feb 10, 2025 · 0 comments · May be fixed by eclipse-platform/eclipse.platform.swt#1877
Assignees
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@akoch-yatta
Copy link

akoch-yatta commented Feb 10, 2025

Currently there is an inconsistent behavior how files retrieved via ImageFileNameHandler are converted into handles. Currently it is as follows:

Ask ImageFileNameHandler for file for targetZoom

  • If perfect match -> call initNative(...)
  • If no perfect match -> call new ImageData(filename) -> this breaks with some files, e.g.
    tiff_image.zip

We need to unify this by always calling initNative first to create a scaled variant of it on demand if necessary. Therefor we need to refactor initNative to serve all required use cases.

@akoch-yatta akoch-yatta converted this from a draft issue Feb 10, 2025
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Feb 10, 2025
@akoch-yatta akoch-yatta added this to the 4.36 M1 milestone Feb 10, 2025
@ShahzaibIbrahim ShahzaibIbrahim self-assigned this Mar 4, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in HiDPI Mar 4, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🏗 In Work: Short to 👀 In Review in HiDPI Mar 10, 2025
@HeikoKlare HeikoKlare moved this from 👀 In Review to 🏗 In Work: Short in HiDPI Mar 10, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🏗 In Work: Short to 👀 In Review in HiDPI Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

2 participants