Unify instantiation of image handles in ImageFileNameProvider #1877
+211
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 509 files ±0 509 suites ±0 8m 38s ⏱️ - 1m 42s For more details on these failures and errors, see this check. Results for commit 7dad43f. ± Comparison against base commit 7f381e8. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-235
branch
2 times, most recently
from
8d3985b to
c51c9c9
Compare
ShahzaibIbrahim
changed the title
HeikoKlare
requested changes
Mar 10, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
akoch-yatta
reviewed
Mar 11, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
akoch-yatta
reviewed
Mar 11, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
Initializing image handle only using initNative method for both the cases where zoom is equal to the filezoom and when its not equal to the filezoom. The handle in case of not equal is created temporarily and destroyed later before calling init.
ShahzaibIbrahim
force-pushed
the
master-235
branch
from
832980d to
3c4f49a
Compare
|
Tests that are failing will be resolved once #1898 is merged. So it makes this PR dependent. |
HeikoKlare
requested changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing image handle only using initNative method for both the cases where zoom is equal to the filezoom and when its not equal to the filezoom. The handle in case of not equal is created temporarily and destroyed later before calling init.
Dependent on: