-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passing extra esbuild options for standalone target #54
Conversation
How about |
@brillout I was going to ask you the same thing, so I'll do it that way 👍 |
Released as |
@magne4000 Hi, I just tested this and I get this error:
When I look at the It says the issue is here
This is what I passed to the standalone field:
If I remove it and put |
Indeed. Let me fix that |
Fix released as |
@thomasjm I wanted to let you know that I've released |
Per the discussion on #14.
I threw this together in order to get my SSR builds to be minified. We'll probably want to think carefully about the API, because it may involve directly exposing esbuild-specific options. This could cause problems down the road if
vike-node
wanted to offer alternative bundlers for standalone mode.It would be cleanest to just pass the appropriate Vite configuration through automatically. However, users who want to minify their SSR builds care about fine-grained control of the minification options, and Vite configuration doesn't provide such; see #14 (comment).
CC @magne4000 @brillout @simplecommerce