invalid ParamNameMismatch with classes extending php_user_filter

[pilif]

https://psalm.dev/r/f3e7bae361

the method's third parameter is supposed to be consumed, not rw_consumed. See https://www.php.net/php_user_filter

I think the rw_-prefix comes from the callmap because the parameter is in/out and those prefixes should probably be ignored in general when checking for parameter name matching.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/f3e7bae361

<?php

class NoopFilter extends \php_user_filter
{
    /**
     * @param resource $in
     * @param resource $out
     * @param int $consumed
	 */     
    public function filter($in, $out, &$consumed, bool $closing): int
    {
        return PSFS_PASS_ON;
    }
}

Psalm output (using commit 4b2c698):

ERROR: ParamNameMismatch - 10:40 - Argument 3 of NoopFilter::filter has wrong name $consumed, expecting $rw_consumed as defined by php_user_filter::filter

[weirdan]

Also affects methods/functions called with named arguments: https://psalm.dev/r/093960fb7a

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/093960fb7a

<?php
function s(SQLite3Stmt $s): void {
    $v = null;
    $s->bindParam(
        param: 1,
        var: $v,
    );
}

function f(Collator $c): void {
    collator_sort(object: $c, array: [123]);
}

Psalm output (using commit 4b2c698):

ERROR: InvalidNamedArgument - 6:9 - Parameter $var does not exist on function SQLite3Stmt::bindParam

ERROR: TooFewArguments - 4:9 - Too few arguments for SQLite3Stmt::bindParam - expecting rw_var to be passed

ERROR: InvalidNamedArgument - 11:31 - Parameter $array does not exist on function collator_sort

ERROR: TooFewArguments - 11:5 - Too few arguments for collator_sort - expecting rw_array to be passed