Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary null type from initialized_methods Context property #10610

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Remove unnecessary null type from initialized_methods Context property #10610

merged 2 commits into from
Jan 28, 2024

Conversation

theodorejb
Copy link
Contributor

Also optimize ConfigFileTest slightly.

@weirdan
Copy link
Collaborator

weirdan commented Jan 28, 2024

Looks like yu need to target master instead.

@theodorejb theodorejb changed the base branch from 5.x to master January 28, 2024 22:26
@theodorejb theodorejb changed the title Add missing type declarations and default values to Context Remove unnecessary null type from initialized_methods Context property Jan 28, 2024
@theodorejb
Copy link
Contributor Author

@weirdan Thanks. The type declarations were already added to master, so this PR is much smaller now.

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 28, 2024
@weirdan weirdan merged commit 275dfd8 into vimeo:master Jan 28, 2024
4 of 5 checks passed
@weirdan
Copy link
Collaborator

weirdan commented Jan 28, 2024

Thanks!

@theodorejb theodorejb deleted the context-types branch January 28, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theodorejb @weirdan