Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer warnings #10695

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Fix composer warnings #10695

merged 2 commits into from
Feb 11, 2024

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Feb 11, 2024

These two classes weren't autoloadable because their FQCNs didn't match
the file paths.

These two classes weren't autoloadable because their FQCNs didn't match
the file paths.
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 11, 2024
@weirdan weirdan requested review from danog and orklah February 11, 2024 04:50
@weirdan
Copy link
Collaborator Author

weirdan commented Feb 11, 2024

/cc: @edsrzf

@edsrzf
Copy link
Contributor

edsrzf commented Feb 11, 2024

Oops, sorry about that. Seems like something that CI could have caught somewhere?

@weirdan
Copy link
Collaborator Author

weirdan commented Feb 11, 2024

composer dump-autoload --strict-psr should do the trick

@weirdan
Copy link
Collaborator Author

weirdan commented Feb 11, 2024

Oops, sorry about that. Seems like something that CI could have caught somewhere?

It kinda did (BCC was failing) but nobody bothered to check its output because the PR was targeting the master branch where BC breaks are allowed.

@weirdan weirdan merged commit 5624533 into vimeo:master Feb 11, 2024
41 of 42 checks passed
@weirdan weirdan deleted the fix-composer-warnings branch February 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants