Add criterion benches and restructure testdata #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
criterion
as a dev-dependency infloresta-chain
and a few initial benchmarks. Also moved thetestdata
directory to the root offloresta-chain
, I think it is more organized and visible there.Finally, in
chain_state.rs
I created asetup_test_chain
function in the unit tests, and we avoid callingget_best_block
a second time in thecheck_chain_integrity
method (get both values directly instead of calling it two times).