Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The alarm time is incorrect for the abnormal jobs #258

Closed
timmyhu opened this issue Oct 17, 2017 · 1 comment
Closed

The alarm time is incorrect for the abnormal jobs #258

timmyhu opened this issue Oct 17, 2017 · 1 comment
Assignees
@timmyhu
Labels
bug done review done tested
Milestone
3.0.0-M1

Comments

@timmyhu
Copy link
Contributor

timmyhu commented Oct 17, 2017 •
edited
Loading

When job is abnormal that haven't run until the desired fire time .
If there have execution nodes for the sharding item,but no running and completed node exist, then the alarm time is incorrect. It should be the lastCompletedTime when the node exits and is larger then the mtime of enable node.
@timmyhu timmyhu added the bug label Oct 17, 2017
@timmyhu timmyhu added this to the 3.0.0 milestone Oct 17, 2017
@timmyhu timmyhu self-assigned this Oct 17, 2017
timmyhu added a commit that referenced this issue Oct 23, 2017
@timmyhu
#258 update dashboard
5320896
@he7g
Copy link
Member

he7g commented Jan 23, 2018

already commit to #289

@he7g he7g added the done label Jan 23, 2018
@lanjane lanjane added the tested label Jan 25, 2018
@lanjane lanjane closed this as completed Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timmyhu timmyhu

Labels
bug done review done tested
Projects
None yet
Milestone
3.0.0-M1
Development

No branches or pull requests
4 participants
@kfchu @he7g @timmyhu @lanjane