Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On some condition, failover thread and normal schedule thread execute at the same time #526

Closed
he7g opened this issue Oct 22, 2018 · 0 comments
Closed

On some condition, failover thread and normal schedule thread execute at the same time #526

he7g opened this issue Oct 22, 2018 · 0 comments
Assignees
@he7g
Labels
bug done
Milestone
3.3.0

Comments

@he7g
Copy link
Member

he7g commented Oct 22, 2018 •
edited
Loading

解决方法： 调整shutdown的先后顺序，使得，要么能中止failover线程，要么failover线程就会submit失败。

测试点： 测试该bug场景是否还存在；回归zk掉线时的作业强杀、failover；回归优雅退出时的作业强杀、failover。
@he7g he7g added this to the 3.3.0 milestone Oct 22, 2018
@he7g he7g self-assigned this Oct 22, 2018
@he7g he7g added the bug label Oct 22, 2018
he7g added a commit that referenced this issue Oct 22, 2018
@he7g
#526 fix
e8fee19
he7g added a commit that referenced this issue Oct 23, 2018
@he7g
#526 fix shutdown problem, when job is the disabled SHELL_JOB
0c7df1c
he7g added a commit that referenced this issue Oct 23, 2018
@he7g
#526 add it, that abort java job when stop executor
0dacbbc
he7g added a commit that referenced this issue Oct 24, 2018
@he7g
#526 wait some time for termination, when gracefully shutdown. So som…
5373f5d 
…e job operation can be finished.
@he7g he7g added the done label Oct 24, 2018
@kfchu kfchu closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@he7g he7g

Labels
bug done
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@kfchu @he7g