CollisionFilterEffect: Explicitly pass isPicking to preRender #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Working on my local test, much nicer fix than #9413, thank you!
felixpalmer
added a commit
that referenced
this pull request
Feb 11, 2025
Pessimistress
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9410
Background
As the
isPickingflag was not being passed theCollisionFilterEffectdestroyed the FBO for the non-pickable layers, leading to the layers to then disappear in the render passScreen.Recording.2025-02-10.at.10.40.32.mov
Change List
isPicking = truewhen invokingEffect.preRenderfrom the deck picker