Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARTO: RasterLayer improve shader precision at high zooms #9518

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

felixpalmer
Copy link
Collaborator

Background

Order of instructions in shader (combined with if branch statement) causes precision issues at high zooms

Before:

Screen.Recording.2025-03-11.at.10.54.10.mov

After:

Screen.Recording.2025-03-11.at.10.53.45.mov

Change List

  • Subtract large values from each other before applying small offset to preserve precision

@felixpalmer felixpalmer requested review from donmccurdy and zbigg March 11, 2025 09:59
@coveralls
Copy link

coveralls commented Mar 11, 2025

Coverage Status

coverage: 91.538% (+0.001%) from 91.537%
when pulling de00896 on felix/carto-raster-precision
into 24c8bcc on master.

@felixpalmer felixpalmer merged commit 1e788e6 into master Mar 12, 2025
4 checks passed
@felixpalmer felixpalmer deleted the felix/carto-raster-precision branch March 12, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants