Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): support "fallback array" in package exports field #10504

Closed
wants to merge 6 commits into from
Closed

feat(resolve): support "fallback array" in package exports field #10504

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
165cdef
feat(resolve): support "fallback array" in package exports field
aleclarson Nov 14, 2022
606f126
refactor: overrideConditions
aleclarson Nov 14, 2022
a94200f
fix: add `module` condition by default
aleclarson Nov 14, 2022
296fe46
fix: config bundling regression
aleclarson Nov 14, 2022
4d3c6ac
fix: respect `overrideConditions` and `isRequire`
aleclarson Nov 14, 2022
bb4fbd0
fix: try `resolveExports` call with postfix included
aleclarson Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add module condition by default
  • Loading branch information
@aleclarson
aleclarson committed Nov 14, 2022
commit a94200f853e94c8d0498c5bfbb6eea5dfd63e67d
9 changes: 8 additions & 1 deletion packages/vite/src/node/plugins/resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,14 @@ function packageEntryFailure(id: string, details?: string) {
}

function getInlineConditions(conditions: string[], targetWeb: boolean) {
return targetWeb && !conditions.includes('node') ? ['browser'] : ['node']
const inlineConditions =
targetWeb && !conditions.includes('node') ? ['browser'] : ['node']

// The "module" condition is no longer recommended, but some older
// packages may still use it.
inlineConditions.push('module')

return inlineConditions
}

function resolveDeepImport(
Expand Down