Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove note about firefox not supporting ESM imports in Web Workers #13940

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

DCzajkowski
Copy link
Contributor

Description

According to caniuse.com and my tests, Firefox supports ESM imports in Web Workers as of 114. This PR updates changes introduced in #13223


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DCzajkowski DCzajkowski changed the title [Docs] Firefox now supports ESM imports in Web Workers docs: remove note about firefox not supporting ESM imports in Web Workers Jul 24, 2023
@patak-dev
Copy link
Member

Thanks!

@patak-dev patak-dev merged commit bbd1ffd into vitejs:main Jul 24, 2023
@patak-dev patak-dev added the documentation Improvements or additions to documentation label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants