fix(css): inline css correctly for double quote use strict #19590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: css
p2-edge-case
sapphi-red
force-pushed
the
fix/css-inline-css-correctly-for-single-quote-use-strict
branch
from
4f0dd12 to
95f6d31
Compare
patak-dev
reviewed
Mar 6, 2025
patak-dev
previously approved these changes
Mar 6, 2025
bluwy
reviewed
Mar 7, 2025
bluwy
approved these changes
Mar 7, 2025
sapphi-red
deleted the
fix/css-inline-css-correctly-for-single-quote-use-strict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original code assumed that
use strictis written with single quotes. This is true for common cases as rollup outputsuse strictwith single quotes. But plugins beforevite:css-postplugin might change them to double quotes, and in those cases, this code did not work.Ported from vitejs#79 (rolldown outputs
use strictwith double quotes so without this change it doesn't work; ported now as this would also fix issues not related to rolldown)