fix: set perEnvironmentStartEndDuringDev: true for runnerImport to fix css import
#19598
Conversation
hi-ogawa
changed the title
perEnvironmentStartEndDuringDev when runnerImport to fix css importperEnvironmentStartEndDuringDev: true when runnerImport to fix css import
hi-ogawa
changed the title
perEnvironmentStartEndDuringDev: true when runnerImport to fix css importperEnvironmentStartEndDuringDev: true for runnerImport to fix css import
| server: { | ||
| perEnvironmentStartEndDuringDev: true, | ||
| }, |
There was a problem hiding this comment.
this may bring issues in the future, we can add perEnvironmentStartEndDuringDev: true to the CSS plugin, no?
There was a problem hiding this comment.
I wasn't sure about adding perEnvironmentStartEndDuringDev to css plugins since currently css plugins tracks states based on top level ResolvedConfig, so calling buildStart multiple times can end up breaking the state.
Other plugins such as vite:manifest and vite:assets already use perEnvironmentStartEndDuringDev, but those plugins are written based on "per environment state", but that's not the case for css plugins.
I think there is something I misunderstood about buildStart in general, and for example, my fix on vite-node vitest-dev/vitest#7480 isn't probably good, so I have to revisit this one too. Probably I'll create an issue first.
Description
Related
runnerImportfails on css import withoutperEnvironmentStartEndDuringDev: true#19606Currently
buildStartof internal css plugin is not called and that's causing a cryptic error on css import as reported #19577.