Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package name #3266

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: update package name #3266

merged 1 commit into from
May 5, 2021

Conversation

rivajunior
Copy link
Contributor

Description

This PR is changing the old package name for the new one. From vite-plugin-react to @vitejs/plugin-react-refresh.

Additional context

Also, I have added a missing quotation mark in an example. And changed notes from emphasis to header


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9438a9d into vitejs:main May 5, 2021
"vite-plugin-react can't detect preamble. Something is wrong. " +
"See https://github.com/vitejs/vite-plugin-react/pull/11#discussion_r430879201"
"@vitejs/plugin-react-refresh can't detect preamble. Something is wrong. " +
"See https://github.com/vitejs/@vitejs/plugin-react-refresh/pull/11#discussion_r430879201"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GitHub link seems not working

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, PR welcome

fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Co-authored-by: Rivaldo Junior <rivaldojunior@sas.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants