Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: prefer auto inference #4434

Merged
merged 1 commit into from
Jul 30, 2021
Merged

types: prefer auto inference #4434

merged 1 commit into from
Jul 30, 2021
+9 −13

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Jul 29, 2021

Description

no relevant issues.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sorry, something went wrong.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Jul 29, 2021
@Shinigami92 Shinigami92 self-requested a review July 29, 2021 08:27
Shinigami92
Shinigami92 suggested changes Jul 30, 2021
View reviewed changes
@hyf0
types: prefer auto inference

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
920bc0e
@patak-dev patak-dev merged commit 1134fd0 into vitejs:main Jul 30, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@hyf0 @aleclarson
types: prefer auto inference (vitejs#4434)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ddf9b9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev

@Shinigami92 Shinigami92

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyf0 @patak-dev @Shinigami92