Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the confusing example of server.proxy #4485

Merged
merged 1 commit into from
Aug 3, 2021
Merged

docs: Fix the confusing example of server.proxy #4485

merged 1 commit into from
Aug 3, 2021

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Aug 3, 2021

If you write the actual requested url like this, you will spell /foo again. For example, the actual mapped url of /foo/get is http://localhost:4567/foo/foo/get, which will lead to 404 unless the user Reuse rewrite configuration

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

If you write the actual requested url like this, you will spell `/foo` again. For example, the actual mapped url of `/foo/get` is `http://localhost:4567/foo/foo/get`, which will lead to 404 unless the user Reuse `rewrite` configuration
@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Aug 3, 2021
@patak-dev patak-dev merged commit 2faef0b into vitejs:main Aug 3, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants