Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture pointer when used with bevy_picking #331

Closed
wants to merge 1 commit into from
Closed

Capture pointer when used with bevy_picking #331

wants to merge 1 commit into from

Conversation

globin
Copy link
Contributor

@globin globin commented Dec 5, 2024

This fixes "clicking through" egui when using bevy_picking

aevyrie
aevyrie approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind giving me an author credit commit seeing as this was taken from mod_picking?

@aevyrie @globin
Capture pointer when used with bevy_picking
4088a80 
This fixes "clicking through" egui when using bevy_picking

Co-authored-by: Robin Gloster <mail@glob.in>
@globin globin force-pushed the picking-capture-pointer branch from c63b6e7 to 4088a80 Compare December 9, 2024 08:24
@vladbat00 vladbat00 mentioned this pull request Dec 21, 2024
Merged
@vladbat00
Copy link
Owner

Hi, I'll merge this as part of #338 (couldn't push to this PR directly). I had to gate the functionality behind the render feature as bevy_picking depends on bevy_render.
Thank you @globin and @aevyrie

@vladbat00 vladbat00 closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevyrie aevyrie aevyrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@globin @vladbat00 @aevyrie