Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][PP] Fix intermediate tensor values #13417

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Feb 17, 2025

#13353 cached the intermediate tensors to make CUDA graph work. However, we forgot to copy the values of intermediate tensors to the cached tensors. This PR fixes it.

With this PR and #13339, I've verified that the PP is working with the correct outputs in a single node.

cc @WoosukKwon @ruisearch42

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 17, 2025
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix!

@comaniac comaniac enabled auto-merge (squash) February 17, 2025 19:04
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 17, 2025
@WoosukKwon WoosukKwon disabled auto-merge February 17, 2025 21:37
@WoosukKwon WoosukKwon merged commit 6ac485a into vllm-project:main Feb 17, 2025
56 of 59 checks passed
@comaniac comaniac deleted the inter_tensor branch February 17, 2025 21:39
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-merge ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants