Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add PaliGemma #5189
[Model] Add PaliGemma #5189
Changes from 37 commits
e6352e5
7dfbe44
3fd77fe
ccb0f25
9b5269d
af11afa
a465e85
3e9a12b
c734a17
2d7de4d
2f65bf7
04e4ace
4a9551d
6fd10f1
d08db94
e325630
cbb7c49
7ea7265
9a8cd85
9069831
7cb1cbb
7db6122
df2c007
9ba7aac
6b32a1e
6bfba0a
bdf9334
524db49
7e6f0fd
50ae420
e0828b0
c4fa37f
b09066e
bf4bb58
c1b9ebf
5c0d2ec
0b76ac1
4823852
02b7c21
1651b15
2f94007
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this example? I'm wondering because it seems pretty similar to the llava example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests and examples were made for each model previously because the image-related engine args were different from each model. This is indeed no longer needed after the refactoring we did, and I will open another PR for consolidate them if you're okay with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! Sounds good. Please open the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test is also a bit redundant with
test_llava.py
. Can we refactortest_llava.py
to cover both models?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above.