replace validate_string with datatype #343
Conversation
manifests/actionpolicy/rule.pp
Outdated
| $fact_filter = '*', | ||
| $classes = '*' | ||
| String $agent, | ||
| String $action = 'allow', |
There was a problem hiding this comment.
isn't action more an Enum ?
There was a problem hiding this comment.
is even something other than allow allowed here? https://github.com/puppetlabs/mcollective-actionpolicy-auth#usage
There was a problem hiding this comment.
I'm not sure which values are allowed here. Do you have a list?
There was a problem hiding this comment.
https://github.com/puppetlabs/mcollective-actionpolicy-auth#policy-file-format
Any number of policy lines are permitted. These must be tab delimited lines with either four or five fields (the final field is optional) in the following order:
allow or deny
|
|
||
| file { "${confdir}/truststore.jks": | ||
| -> file { "${confdir}/truststore.jks": |
There was a problem hiding this comment.
why moving them?
why specifying them at all? puppet4 has manifest ordering by default.
There was a problem hiding this comment.
ah this is the new puppet-lint s**t. never mind.
There was a problem hiding this comment.
still leaves the why specifying the relationship at all. :)
| Class['mcollective::client::install'] -> | ||
| Class['mcollective::client::config'] | ||
| Class['mcollective::client::install'] | ||
| -> Class['mcollective::client::config'] |
There was a problem hiding this comment.
Why moving?
From my perspective the old style is nicer.
There was a problem hiding this comment.
we agreed somewhere in the IRC to go with the new puppet-lint style. This is recommended by the style guide. We should discuss the style guide if we don't like it, but not disable the linter.
No description provided.