Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Make client middleware cert configurable #348

Merged
merged 2 commits into from
Nov 26, 2017

Conversation

benningm
Copy link
Contributor

Use

$::mcollective::middleware_ssl_cert_path
$::mcollective::middleware_ssl_key_path

instead of hard coded path for common (client)

@bastelfreak
Copy link
Member

Hi @benningm, thanks for this PR! Two little things:

  • Can you add a unit test for this?
  • Please check the used email in the commits, it isn't associated with your github account

@bastelfreak bastelfreak added the enhancement New feature or request label Nov 11, 2017
Use

$::mcollective::middleware_ssl_cert_path
@benningm benningm force-pushed the activemq-middleware-ssl-cert branch from 478d36f to 227bacb Compare November 26, 2017 15:43
This adds tests for configuration of activemq ssl
middleware settings for cert,key,ca.
@benningm
Copy link
Contributor Author

This adds testing if options are set. Author also has been fixed.

@bastelfreak
Copy link
Member

Thanks!

@bastelfreak bastelfreak merged commit 3a92d30 into voxpupuli:master Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants