This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Parameterize the client config #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Willems <crowley@inuits.eu>
ekohl
suggested changes
Nov 16, 2017
manifests/client/config.pp
Outdated
| @@ -1,5 +1,9 @@ | |||
| # private class | |||
| class mcollective::client::config { | |||
| class mcollective::client::config ( | |||
| $owner = 'root', | |||
There was a problem hiding this comment.
Maybe use the String datatype on all of these?
Signed-off-by: Bart Willems <crowley@inuits.eu>
ekohl
approved these changes
Nov 16, 2017
|
@BartWillems thanks for this PR. Can you take a look at the used email address in your commit? It isn't associated with your github account. |
|
@bastelfreak The email address in the commit is my work address, it is now added to my account; thanks for noticing 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've parameterised the client config, now it's possible to choose the ownership & permissions of the config file.