⭐️ New: Support ESLint 5 #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
force-pushed
the
eslint-5
branch
from
63ff601 to
f0cdc8b
Compare
ChristianMurphy
force-pushed
the
eslint-5
branch
from
f0cdc8b to
3c3a683
Compare
|
Thank you for this PR. I'm seeing a parser problem: vuejs/vue-eslint-parser#26 |
11 tasks
|
How about now |
|
I think this change should be released in a new major version of eslint-plugin-vue. Currently build fails, as vue-eslint-parser requires eslint@5 as peer dependency, and we can't drop Node 4 support out of the blue. I'm going to prepare new beta soon, and will try include this change and drop support for Node 4 there. Thanks for working on it @ChristianMurphy |
Closed
|
I'm closing this one in favor of #532 where @mysticatea updated also mentioned parser :) |
clarkdo
added a commit
to nuxt/nuxt
that referenced
this pull request
Aug 31, 2018
- [ ] babel-eslint babel/babel-eslint#664 - [x] eslint-config-standard-jsx standard/eslint-config-standard-jsx#32 - [x] eslint-config-standard to be stable release standard/eslint-config-standard#123 - [x] eslint-plugin-html - [x] eslint-plugin-import - [x] eslint-plugin-jest - [x] eslint-plugin-node - [x] eslint-plugin-promise - [x] eslint-plugin-standard standard/eslint-plugin-standard#29 - [x] eslint-plugin-vue vuejs/eslint-plugin-vue#504 - [x] eslint-plugin-react https://github.com/yannickcr/eslint-plugin-react/releases/tag/v7.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eslint.org/blog/2018/06/eslint-v5.0.0-released
ESLint 5 drops support for Node 4, updated CI accordingly.