-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid using prefixIdenntifier in esm #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, once this is approved and all passing, we can merge.
@@ -15,10 +15,13 @@ export function processSlot(source = '', Vue = vue) { | |||
`<SlotWrapper v-bind="$attrs">${template}</SlotWrapper>`, | |||
{ | |||
mode: 'function', | |||
prefixIdentifiers: true | |||
prefixIdentifiers: __BROWSER__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may need to update tsconfig (or somewhere else?) to make this compile.
Thanks @elevatebart, is there some way I can test this out to make sure it's going to work how we want it to? Do you have some way of testing (assuming you did with Vite etc)? |
We could create a playground-like environment to run VTU in a vite/ESM environment. The good news is there is no emergency right now as I found an "unclean" workaround. |
I will release this within 24h. |
thank you !!! |
When using VTU within vite, the version used is esm-bundler.
This version imports the esm-bundler of the compiler-core.
This version does not support prefixIdentifier.
I tried to make a conditional build of VTU.