Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-vapor): implement basic usage of v-slot #203

Merged
merged 7 commits into from
May 12, 2024
Merged

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented May 7, 2024

related #154

Complex cases of slots require to wait more runtime modifications, such as slot props and slot + v-for, so this PR will focus on solving simple cases. this will make basic available slots more quickly

This PR will address simple cases first, as complex slot scenarios involving runtime modifications, like slot props and combining slots with v-for, require more time to dev. This approach ensures quicker implementation of slot functionality

  • impl static default slots and name slots.
  • impl dynamic slot name

Demo

Copy link

netlify bot commented May 7, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 58a5a03
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/663f9c19ec0ff90008123694
😎 Deploy Preview https://deploy-preview-203--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 58a5a03
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/663f9c1995f2f80008c80bc3
😎 Deploy Preview https://deploy-preview-203--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 7, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 55.6 kB (+1.49 kB) 18.9 kB (+468 B) 17.2 kB (+423 B)
runtime-dom.global.prod.js 96.6 kB 36.5 kB 32.9 kB
runtime-vapor.global.prod.js 45.2 kB 16.9 kB 15.4 kB
vue-vapor.global.prod.js 98 kB (+1.44 kB) 34.3 kB (+467 B) 31 kB (+410 B)
vue.global.prod.js 154 kB 55.8 kB 49.8 kB

Usages

Name Size Gzip Brotli
createApp 57 kB 21.9 kB 20 kB
createSSRApp 60.4 kB 23.3 kB 21.2 kB
defineCustomElement 59.3 kB 22.7 kB 20.7 kB
vapor 45.6 kB 16.9 kB 15.5 kB
overall 70.7 kB 26.9 kB 24.4 kB

@Doctor-wu Doctor-wu mentioned this pull request May 8, 2024
7 tasks
@LittleSound LittleSound changed the title feat(compiler-vapor): static v-slot feat(compiler-vapor): v-slot for the basic cases May 8, 2024
@LittleSound LittleSound force-pushed the feat/static-v-slot branch from e2dcb69 to 4683a64 Compare May 10, 2024 09:23
@sxzz sxzz force-pushed the feat/static-v-slot branch from feefadd to 2800df5 Compare May 11, 2024 16:01
@sxzz sxzz merged commit 0c33ace into main May 12, 2024
11 checks passed
@sxzz sxzz changed the title feat(compiler-vapor): v-slot for the basic cases feat(compiler-vapor): implement basic usage of v-slot May 12, 2024
@sxzz sxzz deleted the feat/static-v-slot branch May 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants