Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(compiler-vapor/runtime-vapor): finer update granularity #222

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented May 31, 2024

related #154

  • runtime
  • compiler
  • test case

Copy link

netlify bot commented May 31, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 5ae3b9e
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/665cf54a83ecf100084ca791
😎 Deploy Preview https://deploy-preview-222--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 5ae3b9e
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/665cf54a33f16d0008f47af8
😎 Deploy Preview https://deploy-preview-222--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Doctor-wu Doctor-wu mentioned this pull request May 31, 2024
7 tasks
Copy link

github-actions bot commented May 31, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 57.7 kB (+97 B) 19.6 kB (+20 B) 17.7 kB (-5 B)
runtime-dom.global.prod.js 95.1 kB 35.8 kB 32.3 kB
runtime-vapor.global.prod.js 48.3 kB (+3 B) 18 kB (+25 B) 16.5 kB (+9 B)
vue-vapor.global.prod.js 103 kB (+100 B) 36.1 kB (+52 B) 32.5 kB (+34 B)
vue.global.prod.js 152 kB 55.1 kB 49.3 kB

Usages

Name Size Gzip Brotli
createApp 55.4 kB 21.2 kB 19.4 kB
createSSRApp 58.7 kB 22.6 kB 20.6 kB
defineCustomElement 57.7 kB 21.9 kB 20 kB
vapor 48.6 kB (+3 B) 18.1 kB (+29 B) 16.6 kB (+50 B)
overall 69.2 kB 26.2 kB 23.8 kB

@sxzz sxzz changed the title perf(compiler-vaporl): finer update granularity perf(compiler-vapor): finer update granularity May 31, 2024
Copy link
Member

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any plans to refactor the initSlots function?

The runtime initSlots function needs to be refactored for performance optimization. Because it now uses one big firstEffect callback to resolve all dynamic slots, it doesn't optimize performance even if multiple dynamic slots functions are separated out.

@Doctor-wu
Copy link
Member Author

Are there any plans to refactor the initSlots function?

The runtime initSlots function needs to be refactored for performance optimization. Because it now uses one big firstEffect callback to resolve all dynamic slots, it doesn't optimize performance even if multiple dynamic slots functions are separated out.

Yes, the runtime part will be done in this PR as well

@Doctor-wu Doctor-wu changed the title perf(compiler-vapor): finer update granularity perf(compiler-vapor, runtime-vapor): finer update granularity Jun 2, 2024
@Doctor-wu Doctor-wu requested review from LittleSound and sxzz June 2, 2024 11:44
@sxzz sxzz force-pushed the feature-perf-dynamic-slots branch from 446986b to 5ae3b9e Compare June 2, 2024 22:42
@sxzz sxzz merged commit 8a59311 into main Jun 2, 2024
11 checks passed
@sxzz sxzz changed the title perf(compiler-vapor, runtime-vapor): finer update granularity perf(compiler-vapor/runtime-vapor): finer update granularity Jun 2, 2024
@sxzz sxzz deleted the feature-perf-dynamic-slots branch June 2, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants