T7246: strip version strings on config load #16
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After T7246, the lexer no longer ignores lines beginning with '//', namely, the component version string lines; explictly strip before load.
jestabro
changed the title
dmbaturin
approved these changes
Mar 25, 2025
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
After vyos/vyos1x-config#35, the lexer no longer ignores lines beginning with '//', namely, the component version string lines; explictly strip before load.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos1x-config#35
Proposed changes
How to test
Checklist: