Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6525: Add default dir for ext-scripts without absolute path #3827

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

HollyGurza
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

touch /config/user-data/test.sh
set service snmp script-extensions extension-name tst script test.sh 
commit

Smoketest result

vyos@vyos:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_service_snmp.py 
test_snmp_basic (__main__.TestSNMPService.test_snmp_basic) ... ok
test_snmp_script_extensions (__main__.TestSNMPService.test_snmp_script_extensions) ... ok
test_snmpv3_md5 (__main__.TestSNMPService.test_snmpv3_md5) ... 
service_snmp: ConfigError('Group membership required for user "vyos"!')


service_snmp: ConfigError('Must configure "view" for group "default_group"!')

ok
test_snmpv3_sha (__main__.TestSNMPService.test_snmpv3_sha) ... 
service_snmp: ConfigError('Must configure "view" for group "default"!')

ok
test_snmpv3_view_exclude (__main__.TestSNMPService.test_snmpv3_view_exclude) ... ok

----------------------------------------------------------------------
Ran 5 tests in 24.846s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jul 18, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jul 18, 2024

👍
No issues in unused-imports

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

@HollyGurza HollyGurza requested a review from c-po July 22, 2024 06:15
@c-po c-po merged commit 1f5cb9d into vyos:current Jul 22, 2024
13 of 14 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Oct 8, 2024

backport circinus sagitta

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants