Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T7136: sflow check listen address for the vrf #4348

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

sever-sever
Copy link
Member

Change summary

Add check list to VRF address for the sFlow agent address

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

config:

set interfaces ethernet eth2 address '192.168.0.1/24'
set interfaces ethernet eth2 vrf 'OVERLAY'
set system sflow server 192.168.0.10
set system sflow agent-address 192.168.0.1
set system sflow interface eth1
set system sflow vrf 'OVERLAY'
set vrf bind-to-all
set vrf name OVERLAY table '300'
commit

Before fix:

vyos@r14# commit
[ system sflow ]
Configured "sflow agent-address 192.168.0.1" does not exist in the
system!
[[system sflow]] failed
Commit failed
[edit]
vyos@r14# 

After this fix commit without issues.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Add check list to VRF address for the sFlow agent address
@sever-sever sever-sever requested a review from a team as a code owner February 17, 2025 10:37
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Feb 18, 2025
@c-po c-po merged commit 32c4bea into current Feb 18, 2025
15 of 18 checks passed
@sever-sever sever-sever deleted the sever-sever-patch-1 branch February 18, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current
Development

Successfully merging this pull request may close these issues.

3 participants