Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: T5400: evaluate OPAM environment before package build #4379

Merged
merged 1 commit into from
Mar 4, 2025
Merged

GitHub: T5400: evaluate OPAM environment before package build #4379

merged 1 commit into from
Mar 4, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 4, 2025 •
edited
Loading

Change summary

When moving libvyosconfig to vyos-1x package build process, we need the OPAM environment first.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner March 4, 2025 15:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit a4ba60b into current Mar 4, 2025
12 checks passed
@c-po c-po deleted the c-po-patch-1 branch March 4, 2025 15:03
@vyosbot vyosbot added the mirror-initiated This PR initiated for mirror sync workflow label Mar 4, 2025
@kumvijaya kumvijaya removed the mirror-initiated This PR initiated for mirror sync workflow label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-po @jestabro @kumvijaya @vyosbot