ipsec: T7225: fix IKE DiffieHellmanGroup and ExtendedAuthEnabled in iOS profile #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is unset, loading the iOS VPN profile will error out on the device giving: Profile Installation Failed configuration is invalid: Missing identity My first assumption was an empty string in LocalIdentifier for IKE, but turned out only adding this flag solved it. This was made optional in commit e97d86e ("T6617: T6618: vpn ipsec remote-access: fix profile generators") but got reverted now.
… profile Commit e97d86e ("T6617: T6618: vpn ipsec remote-access: fix profile generators") added a bug when working with DiffieHellmanGroup, it started becoming a boolead and no longer referencing the DH groups itself. This has been fixed.
|
👍 |
c-po
changed the title
c-po
added
bp/sagitta
dmbaturin
approved these changes
Mar 7, 2025
sever-sever
approved these changes
Mar 7, 2025
|
CI integration 👍 passed! Details
|
vyosbot
added
mirror-initiated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Fix dynamic generation of IKE DiffieHellmanGroup in iOS profile
Commit e97d86e (
T6617: T6618: vpn ipsec remote-access: fix profile generators) added a bug when working withDiffieHellmanGroup, it started becoming a boolean and no longer referencing the DH groups itself. This has been fixed.
iOS18+ always requires ExtendedAuthEnabled to be set, if this is unset, loading the iOS VPN profile will error out on the device
giving:
My first assumption was an empty string in
LocalIdentifierfor IKE, but turned out only adding this flag solved it.This was made optional in commit e97d86e (
T6617: T6618: vpn ipsec remote-access: fix profile generators) but got reverted now.Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: