installer: T7049: Fix GRUB boot with RAID1 #4387
Conversation
Rename directory in EFI system partition from: From: \EFI\VyOS (RAID disk 1) To: \EFI\VyOS This prevents GRUB dropping to a grub prompt rather than showing the VyOS boot menu, after installing with the RAID1 option. Refer bug: https://vyos.dev/T7049
woodsb02
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
|
👍 |
|
@jestabro I believe this was introduced during this commit: Would you be able to review this pull request please? |
|
Yes, thanks @woodsb02 , I will take a look ... |
|
CI integration 👍 passed! Details
|
There was a problem hiding this comment.
PR Overview
This PR fixes an issue where GRUB drops to a prompt instead of displaying the VyOS boot menu during RAID1 installations.
- Updated the GRUB installation call in image_installer.py by removing the RAID disk identifier from the EFI directory name.
Reviewed Changes
| File | Description |
|---|---|
| src/op_mode/image_installer.py | Removed extra id parameter from grub.install to align with new naming |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| @@ -877,8 +877,7 @@ def install_image() -> None: | |||
| for disk_target in l: | |||
| disk.partition_mount(disk_target.partition['efi'], f'{DIR_DST_ROOT}/boot/efi') | |||
| grub.install(disk_target.name, f'{DIR_DST_ROOT}/boot/', | |||
| f'{DIR_DST_ROOT}/boot/efi', | |||
| id=f'VyOS (RAID disk {l.index(disk_target) + 1})') | |||
| f'{DIR_DST_ROOT}/boot/efi') | |||
There was a problem hiding this comment.
Removing the 'id' parameter changes the way GRUB identifies the EFI directory; please ensure that the grub.install function is updated accordingly and that no unintended side effects occur from dropping the RAID disk identifier.
| f'{DIR_DST_ROOT}/boot/efi') | |
| f'{DIR_DST_ROOT}/boot/efi', disk_target.id) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Change summary
Rename directory in EFI system partition from:
From: \EFI\VyOS (RAID disk 1)
To: \EFI\VyOS
This prevents GRUB dropping to a grub prompt rather than showing the VyOS boot menu, after installing with the RAID1 option.
Types of changes
Related Task(s)
Refer bug: https://vyos.dev/T7049
Related PR(s)
How to test / Smoketest result
Create virtual machine with 2 hard drives of identical size.
Boot VyOS nightly ISO, and "install image".
Accept automatically proposed RAID1 arrangement for disks.
Reboot
Before this fix, the GRUB prompt will be displayed upon reboot.
After this fix, the GRUB menu will be correctly displayed and VyOS will boot normally.
Checklist: