Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5400: initialize OPAM environment where it's really needed #4393

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 15, 2025

Change summary

Instead of trying to fix - what we call - "Schroedingers build environment" in the outside world calling this package build, we should rather fix the Makefile/build system..

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

+ gcc -shared  -o '_build/libvyosconfig.so'  '-L/opt/opam/4.14.2/lib/containers/monomorphic' '-L/opt/opam/4.14.2/lib/either' '-L/opt/opam/4.14.2/lib/containers' '-L/opt/opam/4.14.2/lib/fileutils' '-L/opt/opam/4.14.2/lib/menhirLib' '-L/opt/opam/4.14.2/lib/pcre' '-L/opt/opam/4.14.2/lib/ppx_deriving/runtime' '-L/opt/opam/4.14.2/lib/ppx_deriving_yojson/runtime' '-L/opt/opam/4.14.2/lib/xml-light' '-L/opt/opam/4.14.2/lib/seq' '-L/opt/opam/4.14.2/lib/yojson' '-L/opt/opam/4.14.2/lib/vyos1x-config' '-L/opt/opam/4.14.2/lib/re' '-L/opt/opam/4.14.2/lib/bigarray-compat' '-L/opt/opam/4.14.2/lib/stdlib-shims' '-L/opt/opam/4.14.2/lib/integers' '-L/opt/opam/4.14.2/lib/ctypes' '-L/opt/opam/4.14.2/lib/ctypes/stubs' '-L/opt/opam/4.14.2/lib/ctypes-foreign' '-L/opt/opam/4.14.2/lib/ctypes/foreign' '-L/opt/opam/4.14.2/lib/ocaml/threads' '-L/opt/opam/4.14.2/lib/ocaml' -Wl,-soname,libvyosconfig.so.0 '/tmp/camlstartup50a566.o' '_build/lib/apply_bindings.o' '_build/generated/vyosconfig_bindings.o' '_build/lib/bindings.o' '/opt/opam/4.14.2/lib/ctypes-foreign/ctypes_foreign.a' '/opt/opam/4.14.2/lib/ctypes/stubs/ctypes_stubs.a' '/opt/opam/4.14.2/lib/ocaml/str.a' '/opt/opam/4.14.2/lib/ctypes/ctypes.a' '/opt/opam/4.14.2/lib/integers/integers.a' '/opt/opam/4.14.2/lib/bigarray-compat/bigarray_compat.a' '/opt/opam/4.14.2/lib/re/re.a' '/opt/opam/4.14.2/lib/vyos1x-config/vyos1x.a' '/opt/opam/4.14.2/lib/yojson/yojson.a' '/opt/opam/4.14.2/lib/xml-light/xml_light.a' '/opt/opam/4.14.2/lib/ppx_deriving_yojson/runtime/ppx_deriving_yojson_runtime.a' '/opt/opam/4.14.2/lib/ppx_deriving/runtime/ppx_deriving_runtime.a' '/opt/opam/4.14.2/lib/pcre/pcre.a' '/opt/opam/4.14.2/lib/menhirLib/menhirLib.a' '/opt/opam/4.14.2/lib/fileutils/fileutils.a' '/opt/opam/4.14.2/lib/containers/containers.a' '/opt/opam/4.14.2/lib/either/either.a' '/opt/opam/4.14.2/lib/containers/monomorphic/containers_monomorphic.a' '/opt/opam/4.14.2/lib/ocaml/threads/threads.a' '/opt/opam/4.14.2/lib/ocaml/unix.a' '/opt/opam/4.14.2/lib/ocaml/stdlib.a' '-lctypes_foreign_stubs' '-lffi' '-Wl,--no-as-needed' '-lcamlstr' '-lctypes_stubs' '-lintegers_stubs' '-lvyos1x_stubs' '-lpcre_stubs' '-lpcre' '-lthreadsnat' '-lpthread' '-lunix' '_build/stub/init.o' '_build/generated/vyosconfig.o' '/opt/opam/4.14.2/lib/ocaml/libasmrun_pic.a' -lm
make[3]: Leaving directory '/tmp/libvyosconfig'
Generating build/interface-definitions/container.xml from interface-definitions/container.xml.in
Generating build/interface-definitions/firewall.xml from interface-definitions/firewall.xml.in
Generating build/interface-definitions/high-availability.xml from interface-definitions/high-availability.xml.in
Generating build/interface-definitions/interfaces_bonding.xml from interface-definitions/interfaces_bonding.xml.in
Generating build/interface-definitions/interfaces_bridge.xml from interface-definitions/interfaces_bridge.xml.in
Generating build/interface-definitions/interfaces_dummy.xml from interface-definitions/interfaces_dummy.xml.in
Generating build/interface-definitions/interfaces_ethernet.xml from interface-definitions/interfaces_ethernet.xml.in
Generating build/interface-definitions/interfaces_geneve.xml from interface-definitions/interfaces_geneve.xml.in
Generating build/interface-definitions/interfaces_input.xml from interface-definitions/interfaces_input.xml.in
Generating build/interface-definitions/interfaces_l2tpv3.xml from interface-definitions/interfaces_l2tpv3.xml.in
Generating build/interface-definitions/interfaces_loopback.xml from interface-definitions/interfaces_loopback.xml.in
Generating build/interface-definitions/interfaces_macsec.xml from interface-definitions/interfaces_macsec.xml.in

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Instead of trying to fix - what we call - "Schroedingers build environment"
in the outside world calling this package build, we should rather fix the
Makefile/build system..
@c-po c-po requested a review from a team as a code owner March 15, 2025 20:17
Copy link

github-actions bot commented Mar 15, 2025

👍
No issues in PR Title / Commit Title

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit fd2f8dd into vyos:current Mar 16, 2025
18 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants