Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5455: copy known SSH host fingerprints on image update #4403

Draft
wants to merge 4 commits into
base: current
Choose a base branch
from

Conversation

oniko94
Copy link
Contributor

@oniko94 oniko94 commented Mar 18, 2025

Change summary

On running add system image command, ask a user whether to copy the known SSH host fingerprints (known_hosts file) and copy those to persistent storage on update.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5455

Related PR(s)

How to test / Smoketest result

  • Build a .deb package of vyos-1x
  • Install it to any running VyOS image
  • Copy a new ISO image onto the running machine and run add system image vyos-1.x.x.iso
  • Reboot into newly installed image
  • Make sure the command prompts whether to copy the known hosts
  • Make sure the files are copied to the new image
  • Make sure they have correct permissions and ownership

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@oniko94 oniko94 requested a review from a team as a code owner March 18, 2025 09:47
Copy link

github-actions bot commented Mar 18, 2025

👍
No issues in PR Title / Commit Title

@oniko94 oniko94 marked this pull request as draft March 18, 2025 10:01
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant