Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pki: T7249: fix shebang to support CLI backend #4405

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 18, 2025

Change summary

Fixes an error:
interpreter/vyatta-cfg-run: line 162: vyatta_config_commit-confirm': not a valid identifier`

Which prevented to renew the certificates. This will only fix renewing of the certificates. Nothing changed in how daemons will be restarted if a certificate is updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

vyos@vyos:~$ openssl x509 -in /run/ocserv/cert.pem -text | grep "Not "
            Not Before: Mar 18 04:33:16 2025 GMT
            Not After : Jun 16 04:33:15 2025 GMT
vyos@vyos:~$ sudo /usr/bin/certbot renew --config-dir /config/auth/letsencrypt --no-random-sleep-on-renew --post-hook "/usr/libexec/vyos/vyos-certbot-renew-pki.sh" --force-renewal
Saving debug log to /var/log/letsencrypt/letsencrypt.log

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Processing /config/auth/letsencrypt/renewal/vyos.conf
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Renewing an existing certificate for vyos.mybll.net

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Congratulations, all renewals succeeded:
  /config/auth/letsencrypt/live/vyos/fullchain.pem (success)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Hook 'post-hook' ran with output:
 Updating certificates in /etc/ssl/certs...
 0 added, 0 removed; done.
 Running hooks in /etc/ca-certificates/update.d...
 done.
vyos@vyos:~$ openssl x509 -in /run/ocserv/cert.pem -text | grep "Not "
            Not Before: Mar 18 05:06:59 2025 GMT
            Not After : Jun 16 05:06:58 2025 GMT

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Fixes an error:
interpreter/vyatta-cfg-run: line 162: `vyatta_config_commit-confirm': not a valid identifier

Which prevented to renew the certificates. This will only fix renewing of the
certificates. Nothing changed in how daemons will be restarted if a certificate
is updated.
@c-po c-po requested a review from a team as a code owner March 18, 2025 15:11
Copy link

github-actions bot commented Mar 18, 2025

👍
No issues in PR Title / Commit Title

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Mar 18, 2025
@dmbaturin dmbaturin merged commit 62ebdb8 into vyos:current Mar 18, 2025
18 checks passed
@c-po c-po deleted the certbot-T7249 branch March 18, 2025 15:43
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 18, 2025
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants