Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T7246: do not pass unneeded version string to parser #4406

Merged
merged 1 commit into from
Mar 20, 2025
Merged

T7246: do not pass unneeded version string to parser #4406

merged 1 commit into from
Mar 20, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Mar 18, 2025 •
edited
Loading

Change summary

Previously the configtree parser would ignore lines beginning with '//', however this is unnecessarily restrictive. Pass only config information to parser, as the version string is saved separately for reconstruction on render.

So as to avoid even a brief window of broken builds, the order of merge should be as follows:
(1) this PR
(2) vyos/vyos1x-config#35
(3) update libvyosconfig with hash of 2
(4) update vyos-1x Makefile with hash of 3 and add nosetest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos1x-config#35

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro
T7246: do not pass unneeded version string to parser
6dd7dbc 
Previously the parser would ignore lines beginning with '//', however
this is unnecessarily restrictive. Pass only config information to
parser, as the version string is saved separately for reconstruction on
render.
@jestabro jestabro self-assigned this Mar 18, 2025
@jestabro jestabro requested a review from a team as a code owner March 18, 2025 17:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Mar 18, 2025
@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@jestabro jestabro merged commit 39364b6 into vyos:current Mar 20, 2025
18 of 19 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 20, 2025
This was referenced Mar 20, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthurdev sarthurdev sarthurdev approved these changes

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @sarthurdev @c-po @vyosbot