fix: Ignore tag changes to customer-ns after eks instantiation #342
Conversation
WalkthroughA new lifecycle block is added to the EKS module configuration in the Terraform file. This block utilizes the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant TF as Terraform
participant EKS as EKS Module
Dev->>TF: Run terraform plan/apply
TF->>EKS: Load module configuration (including lifecycle block)
EKS-->>TF: Return current state (including tags)
TF-->>TF: Check for changes on tags flagging them to ignore
TF->>Dev: Apply changes without reverting external tag modifications
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/app_eks/main.tf (1)
83-86: Lifecycle Block for Tag Changes:
The new lifecycle block correctly instructs Terraform to ignore changes to thetagsattribute. This aligns well with the PR objective of preventing external modifications to tags (especially those related to customer-ns) from triggering unintended changes after EKS instantiation.Suggestion: Consider adding an inline comment just above the lifecycle block to document the rationale behind ignoring tag changes. This can help future maintainers quickly understand the context and the purpose of this configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/app_eks/main.tf(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Terraform Lint and Format Check
modules/app_eks/main.tf
[warning] 1-1: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files.
[warning] 1-1: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files.
[warning] 1-1: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files.
theishshah
changed the title
There was a problem hiding this comment.
Doesn't work with modules see docs.
https://developer.hashicorp.com/terraform/language/modules/syntax#meta-arguments
The aws provider resources are not available in this repo either. The lifecycle block should work at the provider level (core, aws, single tenant): |
j7m4
dismissed
their stale review
Per comment from @dacbd , this will need changes. My reply has a suggested solution
Fixes INFRA-581
Summary by CodeRabbit